From a2db70b3c845a555f0a6592e9d3b5f50128d367f Mon Sep 17 00:00:00 2001
From: fef <owo@fef.moe>
Date: Fri, 2 Dec 2022 01:00:08 +0000
Subject: [PATCH] rename nop handler to handleNoOp

This also adds the comment in action_bar.js to
status_action_bar.js, clarifying that a future
version could improve this code by modifying
EmojiPickerDropdown.
---
 .../flavours/glitch/components/status_action_bar.js           | 4 ++--
 .../flavours/glitch/features/status/components/action_bar.js  | 4 ++--
 app/javascript/mastodon/components/status_action_bar.js       | 4 ++--
 .../mastodon/features/status/components/action_bar.js         | 4 ++--
 4 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/app/javascript/flavours/glitch/components/status_action_bar.js b/app/javascript/flavours/glitch/components/status_action_bar.js
index 1b88d0ea7f..0a1de5e336 100644
--- a/app/javascript/flavours/glitch/components/status_action_bar.js
+++ b/app/javascript/flavours/glitch/components/status_action_bar.js
@@ -208,7 +208,7 @@ class StatusActionBar extends ImmutablePureComponent {
     this.props.onAddFilter(this.props.status);
   }
 
-  nop = () => {}
+  handleNoOp = () => {} // hack for reaction add button
 
   render () {
     const { status, intl, withDismiss, withCounters, showReplyCount, scrollKey } = this.props;
@@ -317,7 +317,7 @@ class StatusActionBar extends ImmutablePureComponent {
     const reactButton = (
       <IconButton
         className='status__action-bar-button'
-        onClick={this.nop} // EmojiPickerDropdown handles that
+        onClick={this.handleNoOp} // EmojiPickerDropdown handles that
         title={intl.formatMessage(messages.react)}
         disabled={!canReact}
         icon='plus'
diff --git a/app/javascript/flavours/glitch/features/status/components/action_bar.js b/app/javascript/flavours/glitch/features/status/components/action_bar.js
index f93e3d0a3d..619c57685a 100644
--- a/app/javascript/flavours/glitch/features/status/components/action_bar.js
+++ b/app/javascript/flavours/glitch/features/status/components/action_bar.js
@@ -144,7 +144,7 @@ class ActionBar extends React.PureComponent {
     navigator.clipboard.writeText(url);
   }
 
-  nop = () => {} // hack for reaction add button
+  handleNoOp = () => {} // hack for reaction add button
 
   render () {
     const { status, intl } = this.props;
@@ -207,7 +207,7 @@ class ActionBar extends React.PureComponent {
     const reactButton = (
       <IconButton
         className='plus-icon'
-        onClick={this.nop} // EmojiPickerDropdown handles that
+        onClick={this.handleNoOp} // EmojiPickerDropdown handles that
         title={intl.formatMessage(messages.react)}
         disabled={!canReact}
         icon='plus'
diff --git a/app/javascript/mastodon/components/status_action_bar.js b/app/javascript/mastodon/components/status_action_bar.js
index 53b8014b72..01d64062da 100644
--- a/app/javascript/mastodon/components/status_action_bar.js
+++ b/app/javascript/mastodon/components/status_action_bar.js
@@ -243,7 +243,7 @@ class StatusActionBar extends ImmutablePureComponent {
     this.props.onFilter();
   }
 
-  nop = () => {}
+  handleNoOp = () => {} // hack for reaction add button
 
   render () {
     const { status, relationship, intl, withDismiss, withCounters, scrollKey } = this.props;
@@ -369,7 +369,7 @@ class StatusActionBar extends ImmutablePureComponent {
     const reactButton = (
       <IconButton
         className='status__action-bar-button'
-        onClick={this.nop} // EmojiPickerDropdown handles that
+        onClick={this.handleNoOp} // EmojiPickerDropdown handles that
         title={intl.formatMessage(messages.react)}
         disabled={!canReact}
         icon='plus'
diff --git a/app/javascript/mastodon/features/status/components/action_bar.js b/app/javascript/mastodon/features/status/components/action_bar.js
index ce272e4487..095bccfa8a 100644
--- a/app/javascript/mastodon/features/status/components/action_bar.js
+++ b/app/javascript/mastodon/features/status/components/action_bar.js
@@ -186,7 +186,7 @@ class ActionBar extends React.PureComponent {
     navigator.clipboard.writeText(url);
   }
 
-  nop = () => {} // hack for reaction add button
+  handleNoOp = () => {} // hack for reaction add button
 
   render () {
     const { status, relationship, intl } = this.props;
@@ -263,7 +263,7 @@ class ActionBar extends React.PureComponent {
     const reactButton = (
       <IconButton
         className='plus-icon'
-        onClick={this.nop} // EmojiPickerDropdown handles that
+        onClick={this.handleNoOp} // EmojiPickerDropdown handles that
         title={intl.formatMessage(messages.react)}
         disabled={!canReact}
         icon='plus'