mirror of
https://git.kescher.at/CatCatNya/catstodon.git
synced 2024-11-22 23:28:08 +01:00
d386d89179
* Fix invalid votes from the API being accepted Fixes #12556 - Ensure `choice` is an integer instead of silently converting to 0 - Ensure `choice` corresponds to an actual choice of the poll * Please CodeClimate
21 lines
727 B
Ruby
21 lines
727 B
Ruby
# frozen_string_literal: true
|
|
|
|
class VoteValidator < ActiveModel::Validator
|
|
def validate(vote)
|
|
vote.errors.add(:base, I18n.t('polls.errors.expired')) if vote.poll.expired?
|
|
|
|
vote.errors.add(:base, I18n.t('polls.errors.invalid_choice')) if invalid_choice?(vote)
|
|
|
|
if vote.poll.multiple? && vote.poll.votes.where(account: vote.account, choice: vote.choice).exists?
|
|
vote.errors.add(:base, I18n.t('polls.errors.already_voted'))
|
|
elsif !vote.poll.multiple? && vote.poll.votes.where(account: vote.account).exists?
|
|
vote.errors.add(:base, I18n.t('polls.errors.already_voted'))
|
|
end
|
|
end
|
|
|
|
private
|
|
|
|
def invalid_choice?(vote)
|
|
vote.choice.negative? || vote.choice >= vote.poll.options.size
|
|
end
|
|
end
|