8 commits

Author	SHA1	Message	Date
Matt Jankowski	e4e07b1c34	Reduce factory usage across spec/services area (#32098)	2024-10-04 14:11:15 +00:00
Matt Jankowski	f1300ad284	Rename jobs/attachments rspec tag names (#29762)	2024-07-08 16:01:08 +00:00
Matt Jankowski	469028b6d3	Remove unneeded type: :service from spec/services files (#29304)	2024-03-13 08:39:26 +00:00
Matt Jankowski	00341c70ff	Use Sidekiq fake! instead of inline! in specs (#25369)	2024-01-10 11:06:58 +00:00
Matt Jankowski	c42591356d	Fix RSpec/DescribedClass cop (#25104)	2023-06-06 13:58:33 +02:00
Nick Schonning	84cc805cae	Enable Style/FrozenStringLiteralComment for specs (#23790)	2023-02-22 09:55:31 +09:00
Claire	e38fc319dc	Refactor and improve tests (#17386) ... * Change account and user fabricators to simplify and improve tests - `Fabricate(:account)` implicitly fabricates an associated `user` if no `domain` attribute is given (an account with `domain: nil` is considered a local account, but no user record was created), unless `user: nil` is passed - `Fabricate(:account, user: Fabricate(:user))` should still be possible but is discouraged. * Fix and refactor tests - avoid passing unneeded attributes to `Fabricate(:user)` or `Fabricate(:account)` - avoid embedding `Fabricate(:user)` into a `Fabricate(:account)` or the other way around - prefer `Fabricate(:user, account_attributes: …)` to `Fabricate(:user, account: Fabricate(:account, …)` - also, some tests were using remote accounts with local user records, which is not representative of production code.	2022-01-28 00:46:42 +01:00
ThibG	18b451c0e6	Change silences to always require approval on follow (#11975) ... * Change silenced accounts to require approval on follow * Also require approval for follows by people explicitly muted by target accounts * Do not auto-accept silenced or muted accounts when switching from locked to unlocked * Add `follow_requests_count` to verify_credentials * Show “Follow requests” menu item if needed even if account is locked * Add tests * Correctly reflect that follow requests weren't auto-accepted when local account is silenced * Accept follow requests from user-muted accounts to avoid leaking mutes	2019-09-27 21:13:51 +02:00