mirrors/catstodon
1
0
Fork 0
mirror of https://git.kescher.at/CatCatNya/catstodon.git synced 2024-11-29 10:49:04 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Reduce round trips in disputes/appeals spec (#29232)

Browse source
This commit is contained in:
Matt Jankowski 2024-02-16 08:01:15 -05:00 committed by GitHub
parent 117b507df5
commit a316c0e38d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 8 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
spec/controllers/disputes/appeals_controller_spec.rb
View file

@ -10,19 +10,17 @@ RSpec.describe Disputes::AppealsController do
let!(:admin) { Fabricate(:user, role: UserRole.find_by(name: 'Admin')) } let!(:admin) { Fabricate(:user, role: UserRole.find_by(name: 'Admin')) }
describe '#create' do describe '#create' do
subject { post :create, params: params }
context 'with valid params' do context 'with valid params' do
let(:current_user) { Fabricate(:user) } let(:current_user) { Fabricate(:user) }
let(:strike) { Fabricate(:account_warning, target_account: current_user.account) } let(:strike) { Fabricate(:account_warning, target_account: current_user.account) }
let(:params) { { strike_id: strike.id, appeal: { text: 'Foo' } } }
before do it 'notifies staff about new appeal and redirects back to strike page', :sidekiq_inline do
post :create, params: { strike_id: strike.id, appeal: { text: 'Foo' } } subject
end
it 'notifies staff about new appeal', :sidekiq_inline do
expect(ActionMailer::Base.deliveries.first.to).to eq([admin.email]) expect(ActionMailer::Base.deliveries.first.to).to eq([admin.email])
end
it 'redirects back to the strike page' do
expect(response).to redirect_to(disputes_strike_path(strike.id)) expect(response).to redirect_to(disputes_strike_path(strike.id))
end end
end end
@ -30,16 +28,12 @@ RSpec.describe Disputes::AppealsController do
context 'with invalid params' do context 'with invalid params' do
let(:current_user) { Fabricate(:user) } let(:current_user) { Fabricate(:user) }
let(:strike) { Fabricate(:account_warning, target_account: current_user.account) } let(:strike) { Fabricate(:account_warning, target_account: current_user.account) }
let(:params) { { strike_id: strike.id, appeal: { text: '' } } }
before do it 'does not send email and renders strike show page', :sidekiq_inline do
post :create, params: { strike_id: strike.id, appeal: { text: '' } } subject
end
it 'does not send email', :sidekiq_inline do
expect(ActionMailer::Base.deliveries.size).to eq(0) expect(ActionMailer::Base.deliveries.size).to eq(0)
end
it 'renders the strike show page' do
expect(response).to render_template('disputes/strikes/show') expect(response).to render_template('disputes/strikes/show')
end end
end end