Fix clicking on avatar/display opening status instead of profile (#2897)

Fix regression from #2895
This commit is contained in:
Claire 2024-11-11 16:11:24 +01:00 committed by GitHub
parent b7a66c6eac
commit 1ae5f84774
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 25 additions and 27 deletions

View file

@ -372,7 +372,10 @@ class Status extends ImmutablePureComponent {
const { isCollapsed } = this.state;
if (!history) return;
if (e.button === 0 && !(e.ctrlKey || e.altKey || e.metaKey)) {
if (e.button !== 0 || e.ctrlKey || e.altKey || e.metaKey) {
return;
}
if (isCollapsed) this.setCollapsed(false);
else if (e.shiftKey) {
this.setCollapsed(true);
@ -390,8 +393,8 @@ class Status extends ImmutablePureComponent {
}
history.push(destination);
}
e.preventDefault();
}
};
handleToggleMediaVisibility = () => {

View file

@ -18,15 +18,10 @@ export default class StatusHeader extends PureComponent {
parseClick: PropTypes.func.isRequired,
};
// Handles clicks on account name/image
handleClick = (acct, e) => {
const { parseClick } = this.props;
parseClick(e, `/@${acct}`);
};
handleAccountClick = (e) => {
const { status } = this.props;
this.handleClick(status.getIn(['account', 'acct']), e);
const { status, parseClick } = this.props;
parseClick(e, `/@${status.getIn(['account', 'acct'])}`);
e.stopPropagation();
};
// Rendering.